qwik icon indicating copy to clipboard operation
qwik copied to clipboard

Published 20 hours ago • verified publisher icon QwikDev

ui: fix header font sizes

Open reemardelarosa opened this issue 1 year ago • 3 comments

What is it?

  • [x] Feature / enhancement
  • [ ] Bug
  • [ ] Docs / tests

Description

Improve headers font sizes on desktop and mobile.

Use cases and why

  • Before

  • Screen Shot 2022-10-17 at 3 47 17 PM Screen Shot 2022-10-17 at 3 47 00 PM

  • After Screen Shot 2022-10-17 at 3 45 37 PM Screen Shot 2022-10-17 at 3 42 55 PM

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

reemardelarosa avatar Oct 17 '22 07:10 reemardelarosa

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Oct 17 '22 07:10 stackblitz[bot]

Thanks for the PR. Would you be able to break this up into three different PRs?

  • H2 font size change
  • Fix FAQ h2s
  • Snippet update

Thanks

adamdbradley avatar Oct 19 '22 21:10 adamdbradley

@adamdbradley H2 font size change https://github.com/BuilderIO/qwik/pull/1808 Fix FAQ h2s https://github.com/BuilderIO/qwik/pull/1809 Snippet update - someone's changes

reemardelarosa avatar Oct 19 '22 22:10 reemardelarosa