qwik icon indicating copy to clipboard operation
qwik copied to clipboard

feat: Ability to disable default MDX plugins

Open felixsanz opened this issue 3 years ago • 5 comments

What is it?

  • [x] Feature / enhancement
  • [ ] Bug
  • [x] Docs / tests

Description

This PR let the developer disable some MDX plugins that were included by default with qwik-city (only the optional ones and it's opt-in, by default they are enabled like before).

This plugins are remarkGfm, rehypeSyntaxHighlight and rehypeAutolinkHeadings.

It is really useful because when those plugins are disabled, the developer can now pass the same plugins to MDX with a different configuration. Right now it's impossible to re-configure rehypeAutolinkHeadings or to use another syntax hightlighter, for example.

Fixes https://github.com/BuilderIO/qwik/issues/1021.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [x] Added new tests to cover the fix / functionality

felixsanz avatar Sep 19 '22 18:09 felixsanz

@shairez This is #1177. I needed to re-create the PR because of a git mess

felixsanz avatar Sep 19 '22 18:09 felixsanz

Thanks so much @felixsanz !

Summoning the all knowing @adamdbradley to take a second look to verify that everything looks good

shairez avatar Sep 20 '22 22:09 shairez

Would be awesome if merged.

jrson83 avatar Oct 06 '22 21:10 jrson83

lets get this merged soon!

manucorporat avatar Oct 08 '22 00:10 manucorporat

I will look into all this next week!

manucorporat avatar Oct 08 '22 00:10 manucorporat