qwik
qwik copied to clipboard
feat: Docs search
What is it?
- [ ] Feature / enhancement
- [ ] Bug
- [x] Docs / tests
Description
see docs/readme.md
Use cases and why
-
- One use case
-
- Another use case
Checklist:
- [ ] My code follows the developer guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [ ] Added new tests to cover the fix / functionality
⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Algolia Keys | 460923b4319d48cf5d3c9f2121f3e56caac55695 | packages/docs/.env | View secret |
| 4241586 | Generic High Entropy Secret | f79f7155c8320b875ae14abea033150796312e44 | packages/docs/src/components/header/header.tsx | View secret |
| 4241586 | Generic High Entropy Secret | 3f2a8bdd5ff80ebe5716d5bd32eec38fbbeb4b3d | packages/docs/src/components/header/header.tsx | View secret |
| 4241586 | Generic High Entropy Secret | ba3f77a56dc3cef5c729f0c3c84f4569261fe575 | packages/docs/src/components/header/header.tsx | View secret |
| 4241586 | Generic High Entropy Secret | f593238b0bb4f98c8010fe41951108b30c21a89f | packages/docs/src/components/header/header.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
preview on https://yb-qwik.pages.dev/
Amazing job! However I am a bit concerned about the eagerness of executing all react to support this. I would look into QwikReact to not run jS until the user interacts with the searchbar
Amazing job! However I am a bit concerned about the eagerness of executing all react to support this. I would look into QwikReact to not run jS until the user interacts with the searchbar
and could I help with write whole widget in qwik at all ? maybe functionality & accessible feature not comparable to official one, but I will try my best.
progress update: finished the MVP of search written in Qwik. Preview available in the same link https://yb-qwik.pages.dev/ . while it still can be improved for sophisticated UI, But I think it can be done later.
There is some issues currently I'm blocked for importing qwik components in npm
when I import bundled component, showing following errors
Error: QWIK http://localhost:3000/src/docsearch_component_useclienteffect_zrgf0h9ksk4.js#_hW[2] does not export _hW
Tried:
- change
vite.config.tsqwik plugin's option entryStrategy tohookworks fine with appdev.ssr, but failed with appbuild - app directly import lib ts source files, works fine in
dev.ssr&build, but failed withserve
can i see the repo of qwik-algolia search?
Found it! going to see if i can debug the issues with _hW make sure we are using the same version fo qwik, there are not cross compatibility yet
Thank you soo much! This was an amazing amount of work! Brilliant!