qwant-basic-gl-style icon indicating copy to clipboard operation
qwant-basic-gl-style copied to clipboard

Fix missing road names at higher zooms

Open bbecquet opened this issue 5 years ago • 2 comments

Proposes [what seems to be] a working fix for the rendering bug where street names disappear at very high zoom levels, making the map barely usable in some cases.

The fix is to allow overlapping of labels with over features after a threshold zoom, as apparently MapBoxGL rendering algorithm was considering labels in some area were always overlapping something at high zooms… Strangely, this doesn't happen everywhere, but in cities it's really common. So, I'm not sure this fixes the original reason, but it seems to work visually. There are some strange placement issues though, like in the last screenshot here where the names are not centered on the road geometry. Maybe it needs some more investigation.

Production With the fix
maps dev qwant ninja_maps_ localhost_3000_
maps dev qwant ninja_maps_ (1) localhost_3000_ (1)

bbecquet avatar Nov 05 '19 16:11 bbecquet

Also note that this change may (logically) lead to text overlapping on some crossroads

image

amatissart avatar Nov 05 '19 17:11 amatissart

The root cause is described in https://github.com/mapbox/mapbox-gl-js/issues/9095

amatissart avatar Dec 12 '19 16:12 amatissart