typed-css-modules
typed-css-modules copied to clipboard
Quramy
feat: add singleQuote option to allow custom style for keys with dashes
Hello! I'm having this issue when running with webpack, it updates the .d.ts related files changing the style defined by prettier. This shows a lot of false positives changed files because prettier styles our .d.ts files and differs with what the lib does.
Also, keys without dashes get the quotes removed, like a JS object key.
In this PR I address this problem.
Thank you for your work!
PS: the gitatribute files and all are because I'm using windows, and had trouble with the EOL's.
BTW, I'm already using this PR in a codebase with more than 100 less files, and nothing went wrong :+1:
It's not bad that you have a preference for single quotes. I like them better too!!
But you should not modify the style of the original code when making a PR
Your PR has conflicts, and too many modifications (like changes of double quotes for simple ones, or line breaks in texts that are too long). Besides, you have also uploaded some configuration files of your IDE. Like editorconfig, gitattributes, prettier, etc. You shouldn't have committed those files!
Check all of that, update your pull request and maybe one day it will be approved.
I'd be happier with those single quotes too!!
Sry the delay! I just rebased and fixed the extra noise in the code :)