qupzilla icon indicating copy to clipboard operation
qupzilla copied to clipboard

Feature Request: Zoom in when pressing Ctrl+=

Open ghost opened this issue 7 years ago • 9 comments

[Ctrl]+[+] does make it zoom in, but the [Shift] button still has to be pressed. I think it would be better if Zoom In works by pressing [Ctrl]+[=].

ghost avatar Jul 31 '17 07:07 ghost

Platform and QupZilla version please.

Zooms in with Linux/KDE and Ctrl + + without any further modifiers.

Test image:

  • http://wlop.deviantart.com/art/Curse-695646668

Martii avatar Jul 31 '17 18:07 Martii

QupZilla 2.1.99 (3c60b8417a) on Linux. Zooms in without needing to press Shift? I'm using a standard keyboard where to access the + key the Shift has to be pressed.

ghost avatar Jul 31 '17 22:07 ghost

Ahh I see what you mean... not the numeric keypad... thought it wasn't zooming/unzooming for you at all. Confirmed as needing it on the top row of a standard keyboard.

Martii avatar Aug 02 '17 02:08 Martii

This used to work, e.g. it works with the 2.1.2 (5.8) AppImage.

elcste avatar Aug 02 '17 02:08 elcste

What is 'standard' for one, might not be a 'standard' for another. :]

That is to say, with the layout I generally use, I make the plus (+) sign without shift, and as such, zooming is triggered by 'ctrl_+'.

From a quick look-see, Firefox for example behaves the same.

Perhaps the key(s) should be customisable?

Chiitoo avatar Aug 02 '17 13:08 Chiitoo

It would appear from a read of the classes utilized at http://doc.qt.io/qt-5.9/qkeysequence.html that QKeySequence("Ctrl++") would need to contain QKeySequence::ZoomIn from http://doc.qt.io/qt-5.9/qkeysequence.html#StandardKey-enum in every code point for maximum keyboard support. This includes a few others unmentioned and not just Ctrl + +.

Martii avatar Aug 02 '17 14:08 Martii

From a quick look-see, Firefox for example behaves the same.

Firefox zooms for both control + and control = .

elcste avatar Aug 02 '17 15:08 elcste

Hmmm https://github.com/QupZilla/qupzilla/blob/3c60b8417a7e2ab2c831a907aaf54dcd94ab459f/src/lib/app/mainmenu.cpp#L492-L496 is an abstract so this could present an issue with getting maximum keyboard support.

Martii avatar Aug 02 '17 15:08 Martii

Firefox zooms for both control + and control = .

Thanks for that note, elcste. I had either completely forgotten about it, or never knew before now. :] .

Chiitoo avatar Aug 02 '17 18:08 Chiitoo