Mac: Close tab buttons missing

[Martii]

With Qt 5.9 nearing release status from https://wiki.qt.io/Qt_5.9_Release thought I would make this issue to see what is up.

Comparisons:

1. 2.1.2 with Qt 5.8
2. 54949f94f3d309e633de671205a1691040840cc3 with Qt 5.9 Beta 2 and Beta 3

---

1. 
2. 

[r-a-v-a-s]

Confirmed.

[r-a-v-a-s]

They seem to still be there but invisible. When I click in the proper location it will close the tab.

Setting all instances of setTabsClosable to true didn't change anything.

[Martii]

They seem to still be there but invisible.

Yup... no solution yet... Qt 5.9 release didn't resolve it nor did rc1 and rc2.

[Martii]

Qt 5.10 and 5.10.1 ... close buttons on tabs still absent.

[nowrep]

What about with Windows theme? Do you see a close button then?

[Martii]

What about with Windows theme? Do you see a close button then?

Yes.

[Martii]

Linux and Chrome theme is missing them too.

---

Rebuilding now for the commit referenced...

[Martii]

Initial start up screen shot with cc01232 ... not sure what that empty tab is but it did close after I figured you pushed the close button to the right instead of left (briefly saw that in commit).

Windows theme is still the only one that shows an "X" for closing. All other themes it is absent.

[Martii]

Re:

not sure what that empty tab is but

Correction... comes back on open (relaunch of QupZilla)... disappears after new tab click and then close that new tab.

---

Very difficult to describe to get it back to normal and this description will probably change a few times.

Double click the tab also is a path to getting it restored to normal... Initial tab doesn't close unless double clicked; then close action (without button and on that tab only) to the right gets rid of that blank space to the left. Same in all themes (however Linux theme isn't same but still similar in the bug when switching without restarting QupZilla).

---

P.S. I'll be out this weekend starting in a few hours so I won't be able to get back to this until Monday.

[Martii]

@nowrep Do you really want me to release a tab bugged version for OS X here for 2.2.6? e.g. it's probably going to generate some noise that's already been mentioned here by me.

[nowrep]

You can copy the css (and images) that changes close button from Windows theme to all other themes to fix it.

[Martii]

The "blank space" before the tab is present on the Windows theme as of cec7516 ... so not sure that would help.

[Martii]

Here's a video at current HEAD. (sorry about the low capture rate... using all my cores for something else unrelated)

tab_issue.zip

[nowrep]

Well, it's not the only thing that is broken on macOS.This is just a visual bug - current tab is drawn in wrong place.