lazy-load-scrollview icon indicating copy to clipboard operation
lazy-load-scrollview copied to clipboard

Check for notification level depth

Open carmas123 opened this issue 3 years ago • 1 comments

Hi please can you add a level depth check into _onNotifcation method. If you have a list with animated widget that scroll vertically this method is calle endlessly and also _loadMore.

The changes to do are these: At row 61 of lazy_load_scrollview.dart

if (widget.scrollDirection == notification.metrics.axis) {

should turn into

if (widget.scrollDirection == notification.metrics.axis && defaultScrollNotificationPredicate(notification)) {

This check if the scroll came from the real list scroll and not from a scrollable item into it.

Regards Massimo

carmas123 avatar Jul 15 '21 10:07 carmas123

Heya,

Thanks for that! Can you create a PR for it, so you can get credit

QuirijnGB avatar Jul 19 '21 00:07 QuirijnGB