Ledger icon indicating copy to clipboard operation
Ledger copied to clipboard

Kotlin metadata partially missing in final mod jar (extensions)

Open getkirill opened this issue 1 year ago • 0 comments

Expected behavior

All kotlin metadata should be present.

Observed/actual behavior

Some metadata is missing and so you can't quite use extension functions (and probably other types defined outside regular classes) of Ledger in extensions...

Steps/models to reproduce

You can reproduce it in our extension dipix-ledger-police

  1. Publish Ledger v1.2.8 to mavenLocal
  2. Clone extension
  3. try building it
  4. it will yell at you for missing types

What operating system are you running

Linux

Minecraft version

1.20.1

Ledger version

1.2.8

Logs

this is not a crash

Agreements

  • [X] I am running the latest version of the mod.
  • [X] My version of Minecraft is supported.
  • [X] I have searched for and ensured there isn't already an open issue regarding this.

Other

  1. while the reproduction repository uses slightly old version (1.2.8 vs 1.2.9), the issue is present in latest version too.
  2. we fixed it fairly easy - we removed META-INF exclusion in build.gradle(.kts), and it worked and all types were accessible.
    not sure why you had it excluded in the first place but no visible regression was observed when using patched version...

getkirill avatar Oct 13 '23 05:10 getkirill