Ledger icon indicating copy to clipboard operation
Ledger copied to clipboard

Ledger causes a crash when pregenerating chunks with campfires in them

Open MrRubberDucky opened this issue 3 years ago • 0 comments

Expected behavior

  • I start chunk generation with chunky
  • Chunks generate fine and don't crash the server

Observed/actual behavior

  • World is generated fine until a chunk appears with campfires in them (Terralith/or structures) then server crashes

Steps/models to reproduce

  • Pregenerate world with structures or worldgen that have campfires in them
  • Wait for a moment and see it suddenly yeet itself with following error

What operating system are you running

Windows

Minecraft version

1.18.1

Ledger version

1.2.2

Logs

https://pastebin.com/8cv28BqT

Agreements

  • [X] I am running the latest version of the mod.
  • [X] My version of Minecraft is supported.
  • [X] I have searched for and ensured there isn't already an open issue regarding this.

Other

Wesley1808 on Fabric Discord explained it a bit:

Seems to be caused by ledger, logging campfires being extinguished whilst generating new terrain. Ledger seems to expect all instances of WorldAccess to be World, where in your case its ChunkRegion. https://github.com/QuiltServerTools/Ledger/blob/master/src/main/java/com/github/quiltservertools/ledger/mixin/blocks/CampfireBlockMixin.java#L44

Which causes a ClassCastException.

MrRubberDucky avatar Feb 22 '22 16:02 MrRubberDucky