BlockBot icon indicating copy to clipboard operation
BlockBot copied to clipboard

Fixes #26

Open samolego opened this issue 3 years ago • 0 comments

Fixes https://github.com/QuiltServerTools/BlockBot/issues/26

What's happening currently: mod is just passing skin value to the crafatar url which is irrelevant (?), as the value itself needs to be decoded. I'm also not sure if crafatar provides the ability to query textures using minecraft texture url, based on https://github.com/crafatar/crafatar/issues/54 still being open. The https://mc-heads.net/ does support it though.

The whole code part could actually be simplified to always use the new part of method (the one in if), as it would work with regular minecraft skins as well. But that would mean you'd have to abandon crafatar api. I'd like to hear your thoughts on that, therefore I'm marking this as draft :).

samolego avatar Feb 09 '22 08:02 samolego