quilt-template-mod icon indicating copy to clipboard operation
quilt-template-mod copied to clipboard

Adapt the LICENSE renaming in order to account for the file extension

Open EnnuiL opened this issue 3 years ago • 6 comments

On QTM, LICENSE.md is to be considered a valid alternative to the good ol' LICENSE, but if you do try it, the renamed LICENSE will become something like LICENSE.md_example_mod, which is bad

EnnuiL avatar Oct 16 '22 21:10 EnnuiL

README doesn't get included in the jar by default... Besides, you don't have to rename it, you just do from 'README.md' and you're done

triphora avatar Oct 16 '22 21:10 triphora

README doesn't get included in the jar by default... Besides, you don't have to rename it, you just do from 'README.md' and you're done

The buildscript does include it, although the README rename is something inherited from Fabric Example Mod, which I assume it's for clarifying what the LICENSE file belongs to; Although thinking about it? It's only really relevant if you actually include more than one README file which in that case, yeah, it should be added manually

EnnuiL avatar Oct 16 '22 21:10 EnnuiL

The buildscript does include it,

Show me where it does that. It doesn't.

triphora avatar Oct 16 '22 21:10 triphora

The buildscript does include it,

Show me where it does that. It doesn't.

Yes, like I said, the buildscript does include the LICENSE file, and I don't see why we wouldn't do that

EnnuiL avatar Oct 16 '22 21:10 EnnuiL

...🤦‍♀️ I failed at communication; When I said README, I meant LICENSE; i sure love my brain

EnnuiL avatar Oct 16 '22 21:10 EnnuiL

Unfortunately, the attempted solution failed... It has been reverted for now, but yeah, an equivalent one that actually works should be investigated

EnnuiL avatar Jan 14 '23 03:01 EnnuiL