quilt-standard-libraries icon indicating copy to clipboard operation
quilt-standard-libraries copied to clipboard

Dehardcoding "ItemStack.isOf" checks

Open Leo40Git opened this issue 3 years ago • 1 comments

As of Minecraft 1.16, the following items are special-cased using ItemStack.isOf calls (AKA ItemStack.getItem() == SPECIFIC_ITEM_INSTANCE):

  • Bows
  • Crossbows
  • Shields
  • Elytras

This essentially means adding a new variant of any of the above items is impossible without mixins.

I suggest that QSL should dehardcode these checks, to allow for custom bows/crossbows/shields/etc.

I'm not sure if this should be an API necessarily, AFAIK the main thing holding back custom bows/etc is the hardcoded checks.

Leo40Git avatar Jun 23 '21 07:06 Leo40Git

I already have libraries waiting for qsl to pass rfc for these

OroArmor avatar Jun 23 '21 07:06 OroArmor