quilt-standard-libraries icon indicating copy to clipboard operation
quilt-standard-libraries copied to clipboard

Latest qfapi crashes Modpack.

Open netcore10 opened this issue 1 year ago • 5 comments

I had to downgrade QFAPI to beta 19 / QSL, but i worry mods will start requiring later versions of qfapi/QSL.

Sent to both parties (a mod mentioned) because I don't know the fault.

https://mclo.gs/gqx8z98

netcore10 avatar Nov 30 '22 23:11 netcore10

Conflicting mixins:

https://github.com/QuiltMC/quilt-standard-libraries/blob/8e361541dfe3fa6977b5cdae9e38f5062c7b685b/library/entity/status_effect/src/main/java/org/quiltmc/qsl/entity/effect/mixin/LivingEntityMixin.java#L141-L148

https://github.com/Ladysnake/Requiem/blob/44ba13e6e29aa93d73dc7aad0b6f4e4ebc247b97/requiem-core/src/main/java/ladysnake/requiem/core/mixin/possession/possessed/PossessableLivingEntityMixin.java#L335-L349

magneticflux- avatar Dec 01 '22 16:12 magneticflux-

Requiem seems to have gone a bit MIA. I assume this can't be fixed on quilted end? I don't want to bog up your issues page.

netcore10 avatar Dec 05 '22 17:12 netcore10

Requiem seems to have gone a bit MIA. I assume this can't be fixed on quilted end? I don't want to bog up your issues page.

It did work on older Qfapi's, but i assume something changed internally.

netcore10 avatar Dec 05 '22 17:12 netcore10

What change is the addition of the status effects API that introduces APIs related to status effect removal. Our mixin rewrite the method, and actually fixes the thing Requiem tries to fix itself, but due to the nature of those two mixins they are incompatible and I don't think we can fix this on our side.

LambdAurora avatar Dec 05 '22 18:12 LambdAurora

That's fair enough. Luckily i'm sticking with these mods only, so for now i'll just stick with an older Qfapi until i'm forced to ditch requiem.

netcore10 avatar Dec 05 '22 19:12 netcore10