quilt-standard-libraries
quilt-standard-libraries copied to clipboard
API for adding Entity-renaming DataFixes
I noticed SimpleFixes
doesn't have a method for renaming Entities like it does for Items, Blocks, and Biomes. This PR adds that.
Note:
- This is based off of 1.18.2 Minecraft and pasted into GitHub's web editor because I currently don't have enough space on my PC to setup another project in my IDE. So I wouldn't be surprised if I made 1-2 mistakes.
- This has not been tested
I think these Labels
apply:
- Library: misc
- s: waiting for test
- t: new api
hmm, should a test for this be added to testmodV3 as well?
AH! I forgot an import... like I said, I'm working with the webeditor here
just a heads up: I'm currently swamped with work for at least a month. So if testing this is a blocking task, then I won't have time to do it for a while
While we do wanna kill the DFU API later, it doesn't hurt too much to add a few things until it's replacement comes
is there any existing discussion on this planned replacement I can follow? is it being tracked in a GH issue and/or on the discord server?
While we do wanna kill the DFU API later, it doesn't hurt too much to add a few things until it's replacement comes
is there any existing discussion on this planned replacement I can follow? is it being tracked in a GH issue and/or on the discord server?
Leo has discussed some potential ideas for the replacement on the toolchain server's #forum-qsl forum channel
Anyway, I'm fast-tracking this PR's FCP to Monday, December 5th
I'd advise against initiating FCP, because it's currently untested and I'd hate to be the author of potentially non-functional code in QSL. I really don't know if it works, I just know it compiles. Doesn't the tag s: waiting for test
mean we should wait until it's tested?
I'm not sure how lenient we are for betas to potentially have bugs, and I suppose that may be a part of an efficient development cycle, but I feel anything involving the DFU needs to have extra care taken because one of the consequences of any bugs/mistakes here includes world corruption (specifically, messing up all entities in the world)
After some thinking and considering the IRL circumstances, I'm delaying the merging of this PR until I'm able to test it myself; After all, it isn't really as urgent as other merge-before-1.19.3 PRs since DFU API is disabled on 1.19.3