quilt-standard-libraries
quilt-standard-libraries copied to clipboard
QuiltMC
Enchanting Boosters Content Registry
Adds an REA to register blocks that provide a certain amount of enchantment power increase in "Bookshelf Equivalents"
Im not a fan of enchantment_stuff/enchantmentstuff as a package name, there must be a better name than that, no?
(Also is there a reason it isnt consistent?)
Im not a fan of
enchantment_stuff/enchantmentstuffas a package name, there must be a better name than that, no? (Also is there a reason it isnt consistent?)
I was not gonna use it as an actual package name, I just wanted to actually implement it and not spend an hour bikeshedding the name and whether it's supposed to go in the existing block content registry module
Forge uses a method called getEnchantPowerBonus, so I initially used enchantment_power but ended up adding "level".
I wouldn't mind a different name, but I can't come up with anything good.
Maybe enchanting_power? enchanting rather than enchantment since it affects the enchanting process, rather than any enchantment directly. The _level bit feels unnecessary.
I called them enchantment_boosters back in VMulti on 1.16, which is what I created MCDict, the precursor to REAs, for.
Ohh, boosters are a good name; After all, this is a block REA and so, having the registry attachment refer to the blocks themselves would be better;
Maybe enchanting_boosters would be perfect, combining that with the feedback about using "enchanting" instead
I renamed it to enchanting_booster given that all other block attachments seems to be singular.
Actually, what we really should have done is adopt something similar to tag conventions, making this quilt:enchanting_boosters; Unfortunately, we didn't, so oh well, we'll stick with that for 1.19
This has been waiting for way too long; I'm starting the FCP; I still have nitpicks that are important to be addressed, but I decided to do that after merge; after way too much poking, now i'm afraid of annoying more...