quilt-standard-libraries icon indicating copy to clipboard operation
quilt-standard-libraries copied to clipboard

Published 20 hours ago • verified publisher icon QuiltMC

Armor Rendering Registry

Open Leo40Git opened this issue 3 years ago • 6 comments

A quasi-port of the ArmorRenderingRegistry of old, now with LambdAurora Incoprorated brand phases!

This API resides in the new entity_rendering module, inside the new rendering library!

Leo40Git avatar Aug 10 '22 16:08 Leo40Git

Note that ArmorFeatureRendererMixin is somewhat similar to Fabric API's MixinArmorFeatureRenderer. Do my changes make it unique enough, or should I add a Fabric license header to it too?

Leo40Git avatar Aug 10 '22 16:08 Leo40Git

If you copied significant amounts of code then yes

OroArmor avatar Aug 10 '22 17:08 OroArmor

3 out of 5 injections are copied directly from Fabric API, but those copied injections are 2 lines each at most. I'll add the license header, just to be safe.

Leo40Git avatar Aug 10 '22 17:08 Leo40Git

A really nice QoL feature would be being able to define a texture path in an ArmorMaterial, like how vanilla uses the name but instead providing full asset path support, without having to register it.

Platymemo avatar Aug 10 '22 18:08 Platymemo

I'll inject a getTextureIdentifier() method into ArmorMaterial, sure.

Leo40Git avatar Aug 10 '22 18:08 Leo40Git

Main API is ready, testmod needs custom texture/model which are outside of my skills...

Leo40Git avatar Oct 01 '22 16:10 Leo40Git

...accidentally merged with 1.19.3, so changing base branch to that for now. If this isn't good I'll redo the merge targeting 1.19 tomorrow.

But! This API shall be finished!

Leo40Git avatar Jan 01 '23 16:01 Leo40Git

Retargeted for 1.19!

Leo40Git avatar Jan 01 '23 18:01 Leo40Git

Marking as finished for now! There may be a model testmod in the future, but pretty much everything is done.

Leo40Git avatar Jan 06 '23 20:01 Leo40Git