quilt-standard-libraries icon indicating copy to clipboard operation
quilt-standard-libraries copied to clipboard

Published 20 hours ago • verified publisher icon QuiltMC

Item Rendering Extensions

Open Leo40Git opened this issue 2 years ago • 8 comments

A rewritten version of my old item overlay customization API.

Also adds the containing rendering library.

TODO

  • [x] Customizing parts of the overlay
    • [x] Count label
    • [x] Item bar
      • [x] Provide API for multiple item bars
    • [x] Cooldown overlay
  • [x] Callbacks for before/after overlay rendered
  • [x] Javadoc
  • [x] Testmod
    • [x] Count label
    • [x] Item bars
    • [x] Cooldown overlay
    • [x] Before/after render callbacks

Leo40Git avatar Jul 16 '22 15:07 Leo40Git

oooh, remind me to review this later 👀

williambl avatar Jul 17 '22 14:07 williambl

This looks pretty good! but waiting for other people to review it, you need to update to the latest changes, and I suggets adding a test mod.

oliviathevampire avatar Jul 18 '22 16:07 oliviathevampire

Can we get BuiltinItemRendererRegistry as well with this PR? Or do you think it's out of scope?

0xJoeMama avatar Jul 18 '22 17:07 0xJoeMama

Can we get BuiltinItemRendererRegistry as well with this PR? Or do you think it's out of scope?

I'll do that in a separate PR after this one gets merged.

Leo40Git avatar Jul 18 '22 19:07 Leo40Git

You might hate this, but i think this would fit better under the rendering library as an item module. Since this entire module is client side and rendering related, i think it fits better there.

OroArmor avatar Jul 19 '22 21:07 OroArmor

Agreed ^^^

I only just realised this was under the item library.

0xJoeMama avatar Jul 20 '22 08:07 0xJoeMama

IT HATH BEEN MOVED

Leo40Git avatar Jul 20 '22 16:07 Leo40Git

I have committed an initial version of the quad batching API (currently untested since I can't run the testmod for some reason).

Leo40Git avatar Aug 07 '22 09:08 Leo40Git

Closing because man I made this overcomplicated as hell. Will bring back later (possibly after extracting the quad batching stuff into its own PR)?

Leo40Git avatar Oct 01 '22 16:10 Leo40Git

Feels like QSL shouldn't be doing this invasive rendering optimizations, quad batching would fit better in its own rendering optimization mod Imo

maximumpower55 avatar Oct 01 '22 18:10 maximumpower55

This optimization only applies to items customized via this API - Vanilla items (and items from mods that do not use this API) are unaffected.

Leo40Git avatar Oct 01 '22 19:10 Leo40Git

Ah👍

maximumpower55 avatar Oct 02 '22 00:10 maximumpower55