quilt-mappings icon indicating copy to clipboard operation
quilt-mappings copied to clipboard

Run diff workflow on PRs

Open Antikyth opened this issue 1 year ago • 4 comments

I imagine this is not possible, given this comment: https://github.com/QuiltMC/quilt-mappings/blob/23w35a/.github/actions/diff-uploader/index.js#L94-L101 But I think it is good to make an issue for this anyway, as if that is true, then that TODO can be removed and replaced by a brief comment explaining why it's not possible.

Antikyth avatar Sep 06 '23 12:09 Antikyth

If not, perhaps adding another way for diffs to be viewed would be possible. Like, I know the update base workflow works on PRs.

Antikyth avatar Sep 06 '23 13:09 Antikyth

I believe it's a permissions issue that prevents the comment on the pr. I think i said something somewhere, I wonder if I can find it.

OroArmor avatar Sep 06 '23 14:09 OroArmor

@rustbot is used in the Rust repo to reply to PRs automatically, and @bors is used in response to command comments to do certain things. Just for reference.

Antikyth avatar Sep 06 '23 14:09 Antikyth

@rustbot is used in the Rust repo to reply to PRs automatically, and @bors is used in response to command comments to do certain things. Just for reference.

How triagebot works

Triagebot consists of a webserver with several endpoints. The /github-hook and /zulip-hook endpoints receive webhook notifications from the respective services. Triagebot can then respond to those notifications to perform various actions such as adjusting labels.

Antikyth avatar Sep 06 '23 14:09 Antikyth