quilt-mappings
quilt-mappings copied to clipboard
Published
20 hours ago •
QuiltMC
QuiltMC
Feature Flag Mapping
Maps feature flag related code - FeatureFlag, FeatureFlagBitSet, FeatureGroup, and friends. Also maps the sync packet, a number of usages of feature flags, and some creative tab code that interacts with them.
Marking as draft because I'm not confident in some names (like FeatureFlagBitSet) and because the creative tab mappings might be unnecessary for this PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Some reasoning on the names:
-
FeatureFlagGroupis tricky. In strings and mojmap, it's a "universe", but this is a non-descriptive name that has already caused confusion in conversations. Since these are groups of feature flags stored together, I call them groups, but there might be a better way of writing that. -
FeatureFlagBitSetis a set of flags from a particular group, stored using their bitmasks. This could have been called aFeatureFlagSetdirectly, but that's literally a synonym of group, and usingBitSet(hopefully) emphasises their role as a modifiable/copyable collection of flags, rather than part of the flags' definition/configuration like groups are. -
FeatureAndDataSettingsis hard. It's a collection of feature flags and their associated datapacks; this needs to be distinct from both worldgen features while also somehow indicating the datapacks included. The mojmap name is (subjectively) worse. -
FeatureAndDataSettings.MINIMAL,FeatureFlags.VANILLA,MAIN_REGISTRYcould maybe all use one term. Also idk what the difference is betweenDEFAULT_SETandVANILLA_SET -
ItemCollectorcollects item stacks without considering size;GatedItemCollectorimplements that while considering feature flag. Here we diverge from #256, which usesItemStackCollector(better) andSplitStackCollector, which is misleading because all collectors are split, but only this one is feature-gated. -
UnsizedItemStackSetis wordy, and implies that the set itself is unsized, but I couldn't think of a better way of indicating "stack size doesn't matter" that doesn't have the same issue. Feedback appreciated
