quilt-mappings icon indicating copy to clipboard operation
quilt-mappings copied to clipboard

map `TreeDecorator`'s inner class

Open ix0rai opened this issue 1 year ago • 5 comments

fairly straightforward, but I'm not sure about the name of the entire class. I was considering Generator, but since it's replacing already existing blocks instead of generating new ones, I thought BlockReplacer was a good name. Please leave feedback on that specifically though!

ix0rai avatar Aug 27 '22 01:08 ix0rai

I personally don't like the name "BlockReplacer" at all. When it's passed as argument you call it "context" which seems to agree with my opinion.

Kroppeb avatar Aug 27 '22 05:08 Kroppeb

the more I think about it the more I dislike the name but since there's data being sent to it, I don't agree with Context either @Kroppeb how would you feel about simplifying it to Placer?

ix0rai avatar Aug 28 '22 18:08 ix0rai

I added some javadoc and decided to go with the Placer name instead. I think it's a better name since this class is mostly replacing air, and the Block prefix felt redundant, given that the user is providing it BlockStates.

ix0rai avatar Aug 30 '22 17:08 ix0rai

mmh, The thing that kinda annoys me is the fact that the class doesn't really do much appart from being a wrapper around data. The only actual logic is the fact it sorts the lists and provides a utility method for placing vines. In the mean time, Placer doesn't convey the fact it is also used to store the roots, leaves and logs locations.

Kroppeb avatar Aug 30 '22 22:08 Kroppeb

exactly why I haven't been able to decide on a name, it's just such an odd class. do you have any suggestions?

ix0rai avatar Aug 30 '22 22:08 ix0rai