enigma icon indicating copy to clipboard operation
enigma copied to clipboard

Navigator count doesn't update properly when reloading mappings

Open PiTheGuy opened this issue 10 months ago • 3 comments

After doing File > Reload Mappings, The count in the navigator in the upper right doesn't update properly. For classes that were open at the time of reload, when the count updates, it counts all tokens, not just those that match the selected filter.

PiTheGuy avatar Feb 14 '25 18:02 PiTheGuy

that's so weird. will get this fixed asap!

ix0rai avatar Feb 14 '25 21:02 ix0rai

i can't reproduce this in enigma's test project. what are the details of your setup?

ix0rai avatar Feb 18 '25 00:02 ix0rai

I'm using the Minecraft jar with Parchment mappings.

After a bit of debugging, this appears to be a race condition where entries are added to the navigator before the project's remapper has had it's mappings tree populated. When it then tries to look up the token type, the mapping then isn't found in the tree (because it hasn't been populated yet) and so it defaults to TokenType.OBFUSCATED. This results in every mapping being considered obfuscated.

PiTheGuy avatar Mar 08 '25 01:03 PiTheGuy

fixed by #305

supersaiyansubtlety avatar Nov 09 '25 20:11 supersaiyansubtlety