[Feature Request] - Missing dependencies

[Netail]

Summary

When working in a mono repo, you can import packages from the node_modules which are used by other packages within the mono repo, but not listed in the dependency list of the package you are working in. It might be nice to give the user a heads up to include the dependency in their dependency list too.

Example

{
  "name": "package-a",
  "dependencies": {
    "react": "^18"
  }
}

{
  "name": "package-b",
  "dependencies": {
    "react": "^18"
  }
}

{
  "name": "package-c",
  "dependencies": {}
}

As both package a & b use react, the react is installed in the root node_modules, thus allowing it to be imported by package c too. When react is also used in the source code of package c, it should be listed in the dependency or dev dependency list

[QuiiBz]

That's a cool idea, but I'm not sure how we could reliably detect if another package is using a dependency that isn't specified in its own dependencies / devDependencies. At a first glance, we would have to analyze the source code for all packages to detect any import statements, which might be expensive.

Do you have any other idea in mind?

[Netail]

That's a good question, to which I do not have the answer to :(

[alSergey]

eslint-plugin-import has a similar rule.

[Netail]

eslint-plugin-import has a similar rule.

Does it work with monorepo's?

[alSergey]

Yes, it looks for dependencies in the nearest package.json file. I use it in my monorepo.

[QuiiBz]

Closing in favor of https://github.com/QuiiBz/sherif/issues/121, see https://github.com/QuiiBz/sherif/issues/121#issuecomment-2993363062 for a rough idea of how that would work.