Tab-Groups icon indicating copy to clipboard operation
Tab-Groups copied to clipboard

Tabs partly hidden in 55.0a1 (2017-05-03)

Open scheinercc opened this issue 7 years ago • 20 comments

Hi there, With the latest update on Nightly tabs get mostly hidden and symbols/text (">", "+", "▼") in the RHS of the top row are distorted image

55.0a1 (2017-05-03) (64-bit) macOS

scheinercc avatar May 04 '17 05:05 scheinercc

Note: I just filed https://bugzilla.mozilla.org/show_bug.cgi?id=1362305

scheinercc avatar May 05 '17 06:05 scheinercc

I have managed to reproduce this issue on latest Nightly (55.0a1, Build ID: 20170508030204) build. I have also performed a regression range and it seems that the following bug has the changes which introduced the regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1352364

For more details see bug 1362305.

Thanks Muntean! FYI, quote from the bug I created over at bugzilla:

We consolidated our toolbar styling to be the same across all three platforms, so this shouldn't be hard to fix on add-on side by changing their code to use the CSS they use for Windows.

scheinercc avatar May 08 '17 17:05 scheinercc

Can confirm, just updated to Firefox DE 55.0b1 and it looks like this:

screen shot 2017-06-14 at 5 55 04 pm

I'm sad to see this happening. Tab Groups is one of my favorite Firefox plugins (if not the favorite). I've read @Quicksaver's last notice multiple times since he first published it, but I always thought I had more time (until Nov) to find alternatives. 😢

sheharyarn avatar Jun 14 '17 22:06 sheharyarn

Is this only a problem on macOS?

(me being hopeful)

dgutov avatar Jun 14 '17 22:06 dgutov

@dgutov can't say. I don't have a machine running windows and my laptop running linux is gone for repair. I've downgraded to Firefox DE 54.0b14 in the mean time.

sheharyarn avatar Jun 14 '17 22:06 sheharyarn

Is this a bug in Tab Groups or Firefox? Does it occur without the add-on installed?

Kasijjuf avatar Jun 14 '17 22:06 Kasijjuf

Doesn't occur without the addon. It also works fine when the addon is installed but there are no groups. As soon as you create a group, it collapses/squeezes into this thin bar.

sheharyarn avatar Jun 14 '17 22:06 sheharyarn

@dgutov This should be macOS only. As Johann pointed out in the linked bug

This is not something we will undo on Firefox side. We consolidated our toolbar styling to be the same across all three platforms, so this shouldn't be hard to fix on add-on side by changing their code to use the CSS they use for Windows.

P.S.: I quickly installed 55 in a Windows VM and it works fine ;)

scheinercc avatar Jun 14 '17 23:06 scheinercc

Yeah, I'm really wondering about Linux here. :)

dgutov avatar Jun 14 '17 23:06 dgutov

You can test it yourself by installing the current Beta for Linux https://www.mozilla.org/en-US/firefox/channel/desktop/ :)

scheinercc avatar Jun 15 '17 00:06 scheinercc

Thanks. I've already had DE installed, was wondering whether to upgrade to 55.

But oh well. Tried it in a test profile, seems to work fine. 👍 Yay for Linux users.

dgutov avatar Jun 15 '17 00:06 dgutov

Cool. Just remembered ... if you want to test again, next time you might be able to install the Dev Edition instead. The download link on this page currently still links to the outdated Dev Edition v54, but should eventually be based on Beta. In contrast to other versions it will create a new (Developer) Profile which exists in parallel to your default Firefox profile.

scheinercc avatar Jun 15 '17 01:06 scheinercc

For the record, I'm running Dev Edition and it got an update to 55.0 Beta 1 today. I haven't updated yet, just mentioning it for completeness' sake.

mechalynx avatar Jun 15 '17 01:06 mechalynx

Thanks @MechaLynx. Mine has updated now as well. While the link mentioned still points to v54 one could download it and let it update right after the installation I guess.

scheinercc avatar Jun 15 '17 01:06 scheinercc

The tab bar is fixed if the tab group button is moved below the tab bar, f.e. next to the hamburger menu. The word "Test" below is the name of my tab group. grafik

sfleiter avatar Jun 19 '17 18:06 sfleiter

Too easy! Thanks @sfleiter :)

FYI this will break the UI in 56 a little before screen shot 2017-06-20 at 10 32 17 after screen shot 2017-06-20 at 10 27 32

but you can drag the tab group button ("Watch") into the Bookmarks toolbar to prevent this screen shot 2017-06-20 at 10 31 31

scheinercc avatar Jun 20 '17 00:06 scheinercc

FYI, this regression can also be worked around from Tab Groups' Preferences. Make sure the option "Show the name of the active group" is unchecked:

tab_groups_options

This will switch from the Tab Group's name to the extension's icon, like so:

tabs_partly_hidden_in_55_0a1__2017-05-03__ _issue__541_ _quicksaver_tab-groups

jwhitley avatar Sep 04 '17 23:09 jwhitley

jwhitley's fix worked for me. I was having the same issue with Tab Groups 2.1.4 in Firefox 55.0.3 on macOS 10.11.6 (El Capitan).

ghost avatar Sep 20 '17 20:09 ghost

jwhitley's work around worked for me, too, but just want to be sure it is understood that the "feature" of showing the group name is essentially broken by this behavior. Hoping it will be fixed.

rossta0825 avatar Oct 13 '17 04:10 rossta0825