Tab-Groups
Tab-Groups copied to clipboard
Quicksaver
Color scheme should adapt better to Developer Edition theme
Original post by @Aralun from https://github.com/Quicksaver/Tab-Groups/issues/278#issuecomment-256596836:
This may have broken my view, actually. It used to have my Linux GTK dark system theme, now looks like:
As such it is a regression on my end. I'm not entirely sure what can be done about this.
@Aralun that's not supposed to happen of course. Can you please send me a screenshot of what your normal Firefox window looks like? Groups view chooses the light or dark theme based on the colors of a few elements in there, and it's possible I may have missed something in your case.
Please define "normal Firefox window". about:home? Also, if there's a dark theme embedded in Groups, is there any manual override? (possibly via about:config)
"Normal" as in not in groups view, what your browser looks like when you're just... browsing something. With the tabs and the location bar and buttons and things like that. :)
Also I forgot to ask, are you using any kind of theme or userstyle in your Firefox?
is there any manual override?
Yes there is, from the add-ons page on AMO.
extensions.tabgroups.forceBrightText - Define which theme to load in groups view. "0" is the default value, the add-on will choose based on your current Firefox and system themes; "1" will always load the light theme, and "2" will always load the dark theme.
I'm using Firefox Dev Edition (to make things easier) with the default Dev Edition theme, also featuring a Stylish theme for GitHub:
Thanks for the hint, I'll now try and manually change the theme. It worked! \o/
Do you need any more information to pinpoint why the auto detection failed?
Alright, the problem here is the dev edition theme. The way the add-on checks for the colors, it thinks that is a light theme, and that was a choice I made because in my testing I saw many cases the dark groups theme just doesn't adapt too well with the rest of the browser.
Obviously not for your case though. I'll think about what the best way would be to adapt the add-on to the dev edition theme. One possibility is to just use the dark theme with the (dark) dev edition theme, I may go with that. Although as I mentioned that won't look too good always, so I may also leave things as-is with the ability to switch themes with that preference.
For now, as long as you can have the correct look, it's not too critical at least, so I'll take some time to test in as many different environments that I can to try to make a decision that will be good for everyone. :)
It seems that the same problem appears with normal Firefox (on Linux Mint with a dark gtk theme):
The Firefox theme is applied only on the tab groups row.
@ugggf that's working as expected, with any other (lightweight) theme such as that one it is supposed to always use the light style. I made some experiments with trying to adapt to dark lightweight themes properly but most of the time it would either not recognize it properly or it would look just plain bad IMO.