Tab-Groups
Tab-Groups copied to clipboard
Quicksaver
In single view don't create a tab group until there's at least one tab in it
In tabbed mode of 2b3 after you click the "new tab group" button, it immediately creates an empty tab group. If you clicked this button by accident, you now have to close the group (and in tabbed mode there's no close button for it).
How it should work: after you click the "new tab group" button, the button itself should act like it's an empty tab group. If user switches to another group, no group will be created. But if user creates a tab in this "fake group" (or moves an existing tab into it) then a real group should be created in place of the "new tab group" button and the button itself should be moved to the right.
I'm assuming by tab mode you mean single view.
you now have to close the group (and in tabbed mode there's no close button for it).
There is. At the top right, after the group title as usual.
How it should work: after you click the "new tab group" button, the button itself should act like it's an empty tab group. If user switches to another group, no group will be created. But if user creates a tab in this "fake group" (or moves an existing tab into it) then a real group should be created in place of the "new tab group" button and the button itself should be moved to the right.
What's the benefit of doing this?
There is. At the top right, after the group title as usual.
Nope.
The benefit is that I don't have to close the group if I accidentally click the "new tab group" button. BTW the tabbed mode is basically an equivalent of virtual desktops and if you look at implementations of virtual desktops that have the "new virtual desktop" button, you'll see that they do the exact thing I described. (E.g. Gnome Shell or Pantheon.)
Further right. Doesn't the close button appear for you there?
The benefit is that I don't have to close the group if I accidentally click the "new tab group" button. BTW the tabbed mode is basically an equivalent of virtual desktops and if you look at implementations of virtual desktops that have the "new virtual desktop" button, you'll see that they do the exact thing I described. (E.g. Gnome Shell or Pantheon.)
I understand what you mean, but I think that's an unfair assessment of what single view represents. I disagree with your suggested behavior because the create new group button functions in exactly the same way as in other modes.
Plus, say you want to set up a basic working space of three of four groups, you wouldn't be able to do that in one go either, you'd have to go back and forth after opening tabs in them so they stick.
@Quicksaver not right, and not good, this will not be a enhancement but a detriment for the addon, if we have a group with some rules, that some time when browsing, tabs will be assigned to it. When this group is empty doesn't mean that we don't have no use to it, I don't want to type rules every time the group is empty, they'll be filled anyway, eve if don't, you can always bring youself to close the group if you have opened it by mistake. 2b4 made this issue invalid.
@iShyboy one of us is missing the point of this issue... What you're suggesting is not closing a group when closing the last tab, which I agree with. That's not what is being discussed here.
@Quicksaver I guess I did not made myself clear,
The first comment says, if you tap the plus button on single view, if you not go there and tap on the plus button on the group and create a tab in it, the group would be closed when you chose another tab or group.
As he said in:
"How it should work: after you click the "new tab group" button, the button itself should act like it's an empty tab group. If user switches to another group, no group will be created. But if user creates a tab in this "fake group" (or moves an existing tab into it) then a real group should be created in place of the "new tab group" button and the button itself should be moved to the right."
In 2b4 we have a way to set rules to this group, even if it is empty, it'll be filled, eventually. So... why close it? Even if you solve the issue and only did not close when there's some rule set, it'll do more bad than good.
if you not go there and tap on the plus button on the group and create a tab in it, the group would be closed when you chose another tab.
I don't believe that's what he meant with:
In tabbed mode of 2b3 after you click the "new tab group" button, it immediately creates an empty tab group. If you clicked this button by accident, you now have to close the group
this button = create new group button.
As in, from the moment you create a group, you yourself have to close it. So if you create a group by accident, you have to close it explicitly, which would be avoided when creating a new group but then doing nothing with it.
Of course, setting rules in it classifies as doing something with it, so it wouldn't be closed or anything in that case. ;)
I understand what you meant, but, if you create a empty group, then did nothing with it, but go somewhere browse the rules you want to set up. When you go back you'll have to create it again.
The question I'm trying to raise is, how many times you click there by mistake that you don't want to bother yourself closing it, and how many times you click it, and he have a use, even if not immediate.
I guess something like in the tabs: https://my.mixtape.moe/evapkc.mp4 Where you tap and close it from whatever group you are at, its a more wise way to solve it, someone already suggested it I guess.
I understand what you meant, but, if you create a empty group, then did nothing with it, but go somewhere browse the rules you want to set up. When you go back you'll have to create it again.
To be fair, I think that's the only non-tab related way to "make use of a group", other than giving it a name I guess. And I'm estimating that the percentage of users actually making use of those rules will be very small; not a lot of people know how to use regular expressions in the first place. I think it's unfair to use that case in comparison with the usage of the new single view, which will definitely far more acceptance by all kinds of users.
:question: why does this only affect "single view". I see the exact same case for "grid display" and "free arrange" mode?!
:tipping_hand_man: I would prefer that creating a tabgroup, will automatically open a tab ... but thats my personal view.
:bulb: Perhaps this might be related to the browser setting browser.tabs.closeWindowWithLastTab (defaults to true) and the tabGroup setting extensions.tabgroups.closeIfEmpty (defaults to true).
if closeWindow is set to false, that typically means "never leave the browser but auto open an empty tab if there is none" ... this might be perhaps the case that makes it fluently consequent to auto OPEN a tab if you create an empty tab group. With that change, normal users are not affected ... but I'm not sure this covers all cases of the users above, yet
why does this only affect "single view". I see the exact same case for "grid display" and "free arrange" mode?!
Because in other modes, there is a visual degree of organization that can be important. For instance, you may be creating groups that you know you'll be using sometime later, even if you don't immediately open a tab in them, and you know where they are (visually) from the start this way. In single view this doesn't matter because there's no visual placement.
I would prefer that creating a tabgroup, will automatically open a tab ... but thats my personal view.
Paragraph above. Also, creating an empty group gives you a big "create new tab" button in case you want to immediately open a tab in it, it should be just an extra click, hardly impeding any kind of workflow I would believe.
Perhaps this might be related to the browser setting browser.tabs.closeWindowWithLastTab (defaults to true) and the tabGroup setting extensions.tabgroups.closeIfEmpty (defaults to true).
Neither play a part in opening groups. browser.tabs.closeWindowWithLastTab is completely ignored if you have the add-on (because it doesn't make sense then, that preference implies that all your tabs are visible, which is just not a correct assumption with Tab Groups).
extensions.tabgroups.closeIfEmpty is explained in the add-on's preferences page, under "Automatically close empty groups". Yes, empty groups will be closed automatically with this preference enabled, but that's not what's being discussed. This is about whether you can keep clicking the plus button in single view to keep opening new groups, or have it no-op (or even hide that button) until you do something with the last new group, such as giving it a name or some catch rules or opening a tab in it.