XCoordinator-Example icon indicating copy to clipboard operation
XCoordinator-Example copied to clipboard

Implement Example in Combine

Open Rion-Kaneshiro opened this issue 5 years ago • 3 comments

#8 Reimplemented the Example using Apples Combine Framework and CombineCocoa instead of RxSwift and RxCocoa.

Caution: This will remove the RxSwift implementation and should not be merged into master. It should reside in a separate branch to provide a comparison between both Frameworks.

Rion-Kaneshiro avatar Mar 02 '20 20:03 Rion-Kaneshiro

Thank you very much for the effort - I will have a deeper look in the coming days. It looks very promising so far, even though, I'm not sure whether the actions actually make much sense in that form - but I can currently also not think of a drastically better option 🙈

pauljohanneskraft avatar Mar 03 '20 18:03 pauljohanneskraft

Well they don't really make sense and I'll see what I can do to improve it ^^

Rion-Kaneshiro avatar Mar 03 '20 19:03 Rion-Kaneshiro

Since the "Action" framework consists of more or less only one single file, we may be able to replicate it and thereby make it more similar to the Rx code. However I'm not quite sure whether that fits the "Combine style".

pauljohanneskraft avatar Mar 03 '20 19:03 pauljohanneskraft