Nimble icon indicating copy to clipboard operation
Nimble copied to clipboard

Published 20 hours ago • verified publisher icon Quick

Be more careful about threading and notifications

Open johnmckerrell opened this issue 2 years ago • 3 comments

Make sure that Nimble doesn't try to access notification properties from the main thread as they may have been created on another thread and get upset (most likely when Core Data is involved). Fixes #973

  • [x] Does this have tests?
  • [ ] Does this have documentation?
  • [ ] Does this break the public API (Requires major version bump)?
  • [ ] Is this a new feature (Requires minor version bump)?

johnmckerrell avatar Mar 25 '22 21:03 johnmckerrell

I'd like to get this in the next release. Approved running the tests here.

younata avatar Apr 14 '22 20:04 younata

This needs some more work and thought on it, and I don't want to gate v10 on it. It's definitely valuable work, but it can also wait until v11.

younata avatar Apr 19 '22 22:04 younata

Thanks for the feedback (wow, 13 days ago), I certainly don't want to dump a PR and run away but it will probably be a little while longer before I can make any further changes FYI.

johnmckerrell avatar Apr 28 '22 09:04 johnmckerrell

Bumping this to the next (major?) release in favor of getting async/await support out the door sooner.

younata avatar Oct 31 '22 21:10 younata

Hi John! After a bunch of noodling on this, I forked your fork and made a PR that includes these changes + some feedback: https://github.com/Quick/Nimble/pull/1051

This will get merged shortly. Thanks for being patient!

younata avatar Apr 11 '23 16:04 younata