Nimble icon indicating copy to clipboard operation
Nimble copied to clipboard

Make Nimble compile for watchOS.

Open danielsaidi opened this issue 3 years ago • 4 comments

  • [x] I have read CONTRIBUTING and have done my best to follow them.

Nimble doesn't compile for watchOS, since throwAssertion uses an exception type that isn't available for watchOS. This has been a problem for a long time and makes it hard to use Quick and Nimble in projects and packages that target watchOS.

While a real solution may be larger undertaking (one such PR already exists), I have created a pull request that disables the part that doesn't compile. Since only throwAssertion is affected, it's a very small tweak to a single place in the library.

With this tweak, developers will get a descriptive message and have the choice to either just not unit test on watchOS or to disable tests that rely on throwAssertion. This will at least make the code compile, which will be a huge improvement.

danielsaidi avatar Dec 30 '21 10:12 danielsaidi

@ikesyo Any progress on this? I'd love to get my PR merged and released, so that I don't have to use my own forks in my various watchOS supporting projects. Lmk if I can help in any way.

danielsaidi avatar Jan 18 '22 08:01 danielsaidi

Hey @danielsaidi, I merged your linked PR. I'd like to see CI building/running on watchOS, as well as the watchOS targets added to the xcodeproj before we actually release watchOS support. If you're able to, I'd love to see a PR for those.

I'll leave this open as we don't yet have watchOS support.

younata avatar Apr 15 '22 03:04 younata

That's great - thank you! I'd love to take a look at it if I get some time on my hands. If so, I'll write more here. 👍

danielsaidi avatar Apr 15 '22 06:04 danielsaidi

In the interest of getting v10 out the door sooner, I'm going to move watchOS support to the next major release.

younata avatar Apr 19 '22 22:04 younata

This was done a few months ago, but forgot to close this. Closing it now!

younata avatar Oct 21 '22 04:10 younata