Chris
Chris
Our PacketTypes.cs naming contains a mix of `Verb` `ActualPacketName` and plain `ActualPacketName` (e.g., `Create` `CombatText`, `Complete` `AnglerQuest`, etc.) I don't really see any renaming that provides extra clarity (from the...
Marking as stalled. This is still a bad packet that does multiple things with no common base
My quick 2c on what a new system needs: * Relational persistence model - the current persistence model is, like all the TShock db tables, a mess. However TShock should...
From reading the above, I'd say our primary problem is figuring out what the *most important* field of a ban is - i.e., for any given player, what data identifies...
imo that's still too much overhead for the use case that most people have. This kind of thing needs to be done with as little removal from the game as...
A ban ID doesn't uniquely identify anything except a ban record. A properly structured table should not need arbitrary identity columns - you should be able to uniquely identify any...
idk how to do a pretty table but I was thinking more along the lines of `SCHEMA(Time [CK, datetime], Target [CK, varchar], Expires [datetime?])` = Ban table `SCHEMA(Time [FK, datetime],...
From #1464: Ban message displayed to user should be customisable
Also fragment blocked
@nicatronTg Orion contains service _definitions_, TS5 will contain concrete implementations. E.G., IUserAccountService would be in Orion, while PlainTextAccountService would be part of TShock