Max Ehrlich

Do you know whose bug it is and where I can file it?

Actually it turns out that changing the signal alone wasnt enough to fix the problem so now I'm trying to figure out how this was ever working for me (it...

OK I figured it out, seems like at some point lightning added the following: ``` if sigusr1_handlers and not self._has_already_handler(signal.SIGUSR1): self._register_signal(signal.SIGUSR1, HandlersCompose(sigusr1_handlers)) def _has_already_handler(signum: _SIGNUM) -> bool: return signal.getsignal(signum) not...

I contributed a fix to PL already that lets users change the signal to whatever they want, so I can tell it to use SIGUSR2 now. 1. Lightning was assuming...

I can't even find any discussion about this using git blame because the ssim files have been moved around so many times Anyway I have a fixed implementation of this...

I have a prototype for SSIM, probably will have something complete for a draft PR early next week

I'm curious if you have any testimonials from people who are using the image metrics in production code With the current implementation I don't see how it's possible outside of...

That's definitively possible, I'm still scoping out what exactly is required for the other metrics

BTW it looks like the "none" reduction is broken for MS-SSIM. If you pass anything larger than a batch size of 1 it crashes because the shapes of things aren't...

Is there any particular objection to depending on pytorch-mssim instead of reimplementing this? The current implementation seems to be very broken, pytorch-mssim supports everything that it needs and it is...