mcaselector icon indicating copy to clipboard operation
mcaselector copied to clipboard

Modified zulu JRE-FX installation

Open dylanvu opened this issue 3 years ago • 5 comments

Modified documentation for the "Download and installation" section under the "With zulu JRE-FX:" subsection. The jar file is no longer named mcaselector-1.16.2.jar so following the original directions yields a "Unable to access jarfile mcaselector-1.16.2.jar" error. The jar file downloaded is named mcaselector.jar and having users drag and drop will be easier for the future.

dylanvu avatar Jun 12 '21 00:06 dylanvu

I'm not sure what you mean? When you download the executable jar file from any release, it always has the format mcaselector-<version>.jar. When there's a new release, the Readme and any other files that contain the current version are updated using the gradle task updateReadme.

Querz avatar Jun 13 '21 21:06 Querz

Gotcha, I also wasn't aware that the readme is updated via Gradle, sorry. I'm also not too familiar with Gradle as well.

I installed mcaselector using the "Version 1.16.2 (Windows Installer)" and I got a jar file that is named "mcaselector.jar" without any version at the end, so I figured that the documentation wasn't updated. I did not change anything during the installation, nor did I rename the jar file. It seemed to have come like this.

Might I suggest changing the documentation to "dragging and dropping" instead of typing the jar file name to avoid this issue?

image

If you feel like this overall isn't too big of an issue we can close the pull request

dylanvu avatar Jun 14 '21 23:06 dylanvu

I see... This looks like a problem with the Installer though, because it is supposed to download the JRE for you. If that would have worked, you would see a folder called jre in there containing a zulu JRE-FX installation.

Can you tell me if you had any errors while using MCA_Selector_Setup.exe to install MCA Selector?

Querz avatar Jun 15 '21 14:06 Querz

I didn't have any errors while using the MCA_Selector_Setup.exe but I did have to download the zulu JRE-FX for Windows.

dylanvu avatar Jun 15 '21 22:06 dylanvu

Could you run the installer using this command from PowerShell:

.\MCA_Selector_Setup.exe /LOG=debug.log

And then send me the debug.log file please?

Querz avatar Jun 16 '21 14:06 Querz