NevermoreEngine icon indicating copy to clipboard operation
NevermoreEngine copied to clipboard

Published 20 hours ago • verified publisher icon Quenty

Upgrade Installer

Open Validark opened this issue 5 years ago • 3 comments
trafficstars

Finally got around to refactoring the Installer. It now works using Promises and GitHub's official API, so it shouldn't break anymore :)

(the old version manually scraped GitHub webpages, which led to problems)

I wrote this in TypeScript. See here for the source code (slightly different on some of the Nevermore-specific logic at the end).

Demo the new installer:

local h = game:GetService("HttpService") local e = h.HttpEnabled h.HttpEnabled = true loadstring(h:GetAsync("https://raw.githubusercontent.com/Quenty/NevermoreEngine/600d454c7d7b65b55bc3d0efe224b66217c365d9/Install.lua"))(e)

Fixes https://github.com/Quenty/NevermoreEngine/issues/142

Validark avatar Jul 18 '20 16:07 Validark

Since this isn't a real library, could this be excluded from the lint check?

Validark avatar Jul 18 '20 16:07 Validark

I still think this is relevant. Couldn't install with the installer that's included with the base branch due to an infinite yield with a repeat until loop on line 277. This one worked fine.

camren-m avatar Jul 27 '20 23:07 camren-m

You could add --luacheck: ignore at the top, but I'd prefer someone fix the linting. Either way is fine.

Quenty avatar Jul 28 '20 01:07 Quenty