json-bourne icon indicating copy to clipboard operation
json-bourne copied to clipboard

Fix 6-year old padding bug, upgrade dependencies

Open oliverwoodings opened this issue 4 years ago • 2 comments

This was identified through SonarQube!

We have been incorrectly constructing ISO date strings for over 6 years now, which is ironic because the purpose of JSON bourne is to correctly encode dates and other things to the correct standards 🤦

The bug is due to the pad function not supporting a length parameter, but when used in code it was assumed that it does. This means that if the millisecond component of the date being stringified was less than 100, it would only be 2 characters long instead of being correctly padded to 3, and if it was less than 10, it would be 1 character!

Luckily this hasn't actually caused any issues because most date libraries will be able to deal with the missing digits.

I had to update basically every dependency to get this working lol.

oliverwoodings avatar Feb 10 '21 16:02 oliverwoodings

😱

KidkArolis avatar Feb 10 '21 18:02 KidkArolis

Movie on 2-11-21 at 6 05 PM

roberttod avatar Feb 11 '21 23:02 roberttod