qubes-issues icon indicating copy to clipboard operation
qubes-issues copied to clipboard

SALT: `merge_tops` merges in `match: pcre`

Open zaz opened this issue 7 months ago • 1 comments

Qubes OS 4.2.4

Steps to reproduce

  1. Create Qubes debian and debain-12-xfce
  2. Enable a top that targets debian with state-one
  3. Enable a top that targets debian with state-two, but using match: pcre

Expected behavior

state-one is run on debian and state-two is run on both debian and deabian-12-xfce.

Actual behavior

Both states are run on both debian and deabian-12-xfce.

Presumably because the resulting top file looks something like this:

user:
  debian:
    - match: pcre
    - state-one
    - state-two

zaz avatar May 11 '25 10:05 zaz

Perhaps for now we just add a note to the docs that it is important to include ^ and $ in the VM name not only to restrict the match, but also to ensure the VM name doesn't match a non-regex VM name.

zaz avatar May 11 '25 12:05 zaz