Upgrading packages `qubes-core-admin-client`, `python3-qubesadmin` probably should restart `qvm-start-daemon`

[Euwiiwueir]

How to file a helpful issue

Qubes OS release

4.2 and earlier

Brief summary

qvm-start-daemon is a long-running process kicked off at DE startup via /etc/xdg/autostart/qvm-start-daemon.desktop, at least on my system. The executable and its library code are provided by the packages qubes-core-admin-client and python3-qubesadmin. After these packages are upgraded, the old qvm-start-daemon process continues running with its pre-upgrade logic. Which could place the system in an uncertain state if reverse dependencies are expecting the new logic. Unreproducible bugs.

Probably the RPMs should include a post-install scriptlet to check whether qvm-start-daemon is running and kill it + re-run qvm-start-daemon --all --watch. And/or perhaps there should be a systemd unit for qvm-start-daemon for a managed start/stop/restart.

Steps to reproduce

Reinstall qubes-core-admin-client, python3-qubesadmin

Expected behavior

qvm-start-daemon process restarted

(Not without risk, but this would probably be better than not restarting)

Actual behavior

Run ps, notice that qvm-start-daemon has a start time before the packages were reinstalled.