QubesOS
Alert dialog boxes use yellow exclamation "warning" icon even for successful alerts
Qubes OS release
4.2rc3 (but I guess in every Qubes release so far)
Brief summary
After successfully cloning a qube with Qubes Manager, the following dialog is presented:
The yellow exclamation mark scared me because I felt something went wrong. But everything went right.
A yellow exclamation mark is meant for warnings.
Steps to reproduce
Successfully clone a qube with Qubes Manager. The dialog presents itself.
Expected behavior
A green icon showing a "tick" (https://www.htmlsymbols.xyz/unicode/U%2b2705) that everything went well.
Actual behavior
A yellow icon which triggers a reaction that something went wrong when it didn't. See https://en.wikipedia.org/wiki/Exclamation_mark for more information.
This warning sign is misused in other cases in GUI tools of Qubes OS for a long time. E.g. backup recovering successful finish also has message box with a warning exclamation sign (at least was in R4.1).
Perhaps this issue can be closed thanks to https://github.com/QubesOS/qubes-manager/commit/8500b3654523ebd31a66a5880271585c9cba9dc5
Do not close the issue. There are more cases of bad UI and UX with this exclamation warning icons misuse for success. E.g. currently (R4.2 and probably R4.3) successful recovering of qube backup also finishes with Warning icon instead of green check/OK icon.
Do not close the issue. There are more cases of bad UI and UX with this exclamation warning icons misuse for success. E.g. currently (R4.2 and probably R4.3) successful recovering of qube backup also finishes with Warning icon instead of green check/OK icon.
Beside this, anything else? It is necessary to know where they are for them to be fixed.
@jamke: I have looked up the calls to QMessageBox.warning in the entire Qube Manager repository. There are 59 calls. The message for most of them include wordings like Unexpected, Failed, Nothing Selected!, ERROR!, Warning!, Invalid, not found, unavailable, unsupported, unreadable, cannot, cancelled which should justify the yellow exclamation "warning" icon?. The only one which had two cases (Finished successful & Finished with errors!) is the restore case you mentioned earlier. Which should be covered by @kennethrrosen patch.
@kennethrrosen why do you use information status? Does Qt MessageBox have some kind of success icon? Like green check mark or something.
Information is something that I would use for messages that are not related to the process result (e.g. information before the process even started.
I believe QMessageBox has 4 default icons. Question, Information, Warning, Critical
https://doc.qt.io/qtforpython-5/PySide2/QtWidgets/QMessageBox.html#severity-levels-and-the-icon-and-pixmap-properties
Backup being successfully complete is indeed a successful process result. But a sub-category of informative message IMO.
Do not close the issue. There are more cases of bad UI and UX with this exclamation warning icons misuse for success. E.g. currently (R4.2 and probably R4.3) successful recovering of qube backup also finishes with Warning icon instead of green check/OK icon.
If you find any, make an issue for them, let's not do issue creep.
@alimirjamali @marmarta OK, if I face such issue with wrong icons I will notify. Maybe it's the last place left, I do not know others.
As a specialist in UI/UX I was quite disturbed by this warning messagebox for backup recovery for YEARS (from the moment I first saw it) :)