QubesOS
Disabling 'Provides network' for sys-usb confusingly changes menu item prefix and icon.
Qubes OS release
4.1.0
Brief summary
I have sys-usb (minimal version), but I have no intention of setting it as "Provides network" as it does not have networking enabled nor needs to. However, when I uncheck that option, now the menu item for it changes from Service: sys-usb to Qube: sys-usb, which is confusing. In addition, the icon also changes. This may be related to changes made in #6707.
Steps to reproduce
Uncheck "Provides network" for sys-usb.
Expected behavior
Menu item and icon remains Service: sys-usb.
Actual behavior
Menu item and icon changes to Qube: sys-usb.
While this should be addressed (as unchecking "Provides network" shouldn't be a hard dependency for the vm to be considered a "Service", since there are multiple kind of services), you can make the sys-usb qube to act as service again issuing this cmd in dom0
qvm-features sys-usb servicevm 1
Changes were picked instantly after restarting Qubes Manager, however for appmenu, I had to edit the name & icon manually under ~/.local/share/desktop-directories/qubes-vm-directory-sys-usb.directory
Name=Service: sys-usb
Icon=servicevm-red
then restart the panel with xfce4-panel -r
Hopefully there's a command to do this 2nd part automatically with a toggle, but I didn't find it yet.
I've done the above workaround for the issue, but the icon in the Qubes Manager tray menu does not change, and all other icon changes do not persist (menu and Qubes Manager main window). They eventually end up reverting back to the wrong icons. It appears the menu prefix does persist, for now.
It seems like a bug that sys-usb has Provides network enabled by default in the first place on systems with no networking devices in sys-usb. Opened #7669 for that.
