QubesOS
Describe Move user profiles without QWT installation
I don't see a problem with the new text and I cannot find the cause of the error in building. Can I help somehow?
It looks like there is a spelling error somewhere:
+ echo 'Spelling report for 18ee334591aba8b5d65bac8c34c028e85b9a0d54:'
Spelling report for 18ee334591aba8b5d65bac8c34c028e85b9a0d54:
+ echo
+ _utils/spellcheck.sh /home/gitlab-runner/old_site _site
[WARNING] Duplicate identifier 'qubes-canary-039' at input line 292 column 43
[WARNING] Duplicate identifier 'qubes-canary-038' at input line 292 column 43
[WARNING] Duplicate identifier 'introduction' at input line 360 column 35
[WARNING] Duplicate identifier 'qubes-canary-039' at input line 292 column 43
[WARNING] Duplicate identifier 'qubes-canary-038' at input line 292 column 43
[WARNING] Duplicate identifier 'introduction' at input line 360 column 35
The following new unknown spellings were introduced:
+SZ
...
If these are false-positives, simply commit as is and they will
be ignored in the future.
+ all_ok=false
Apparently this is the output of lines 83-93 in gitlabci.sh
This spelling error is somewhere outside my text change. So I suppose that it has been there already before my change, and I propose to accept the change anyhow. Do I need to do anything to accomplish this?
Thanks in advance!
This spelling error is somewhere outside my text change
If you're checking the line numbers of warnings I don't think they have any direct relation to the text file you've changed. The file is 281 lines long even with your contribution.
In addition, the "unknown spelling" line is highlighted in the job log, not the warnings.
Looking into utils/spellcheck.sh, it seems like the function diff_checked is causing the test to fail.
Edit: After staring into spellcheck.sh for some time I am somewhat confident that it spell checks everything and collects suspicious words. Then, it compares suspicious words from the old version of the site with the new version, and fails the check if any suspicious words have been added. Apparently, here it stated that SZ is a newly introduced suspicious word. As far as I understand it refers to REG_MULTI_SZ in the line 240. Unless it is not supposed to be there, that was a false positive.
That makes it clearer! As REG_MULTI_SZ is a legal data type of the registry, this is a false positive, and the text can be accepted as such. Thanks again!
@GWeck Sorry for the delay in getting to this. Is this good to go as is?
Can I ask that you take a look at #1438 also, and update comment there. Thanks
This one is still correct and can be submitted, although it may not be necessary any more once the new QWT version is released - at least I hope so.
#1438 needs some changes with regard to the TPM issue and the oobe patch, but I'll have to check it in detail before describing them. Microsoft again changed the behavior of W11 24H2. (They're doing everything to motivate Windows users to migrate to Linux!)