qubes-core-agent-linux icon indicating copy to clipboard operation
qubes-core-agent-linux copied to clipboard

Support dnf5 for qubes-download-dom0-update.sh

Open alimirjamali opened this issue 1 year ago • 4 comments

dnf5 does not print "--downloadonly" help with -h by default

For https://github.com/QubesOS/qubes-issues/issues/9244

alimirjamali avatar Aug 22 '24 16:08 alimirjamali

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.14%. Comparing base (5b860df) to head (edae40c). Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   70.57%   70.14%   -0.43%     
==========================================
  Files           3        3              
  Lines         469      469              
==========================================
- Hits          331      329       -2     
- Misses        138      140       +2     
Flag Coverage Δ
70.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 16:08 codecov[bot]

Using --version to detect dnf5 in Debian scenario

alimirjamali avatar Aug 22 '24 18:08 alimirjamali

Reason for amendments:

In dnf5:

  1. check-update is renamed to check-upgrade
  2. The order of command & argument does matter very much.

alimirjamali avatar Aug 22 '24 20:08 alimirjamali

PipelineRetry

alimirjamali avatar Sep 08 '24 16:09 alimirjamali