qubes-core-agent-linux icon indicating copy to clipboard operation
qubes-core-agent-linux copied to clipboard

Hint about a possible update failure reason

Open strugee opened this issue 4 years ago • 2 comments

This feels ugly because it doesn't fix the underlying bug, but it's incredibly hard to trace down the root cause in this situation and it causes updates to fail which is pretty critical. So this is probably better than nothing.

Ref QubesOS/qubes-issues#5052

strugee avatar Apr 08 '20 00:04 strugee

Codecov Report

Merging #225 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files           3        3           
  Lines         512      512           
=======================================
  Hits          372      372           
  Misses        140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b02dd6a...dbc2d73. Read the comment docs.

codecov[bot] avatar Apr 08 '20 00:04 codecov[bot]

IMO better than guessing, make the actual error easier to find. It should be written to /var/lib/qubes/updates/errors in dom0, so qubes-dom0-update script may check this file and show it to the user. If that still doesn't contain enough details, you can modify qubes-receive-updates script to save stderr of qfile-dom0-unpacker there too.

marmarek avatar Apr 08 '20 00:04 marmarek