qubes-core-admin icon indicating copy to clipboard operation
qubes-core-admin copied to clipboard

Initialize asyncio event loop before using it

Open alimirjamali opened this issue 4 months ago • 10 comments

Python 3.14 (in Fedora 43) throws RunetimeError if event loop is not initialized before using it.

Resolves: QubesOS/qubes-issues#10188

alimirjamali avatar Aug 28 '25 13:08 alimirjamali

Codecov Report

:x: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.54%. Comparing base (5140b97) to head (7e4a837). :warning: Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
qubes/tools/qubesd.py 0.00% 2 Missing :warning:
qubes/tools/qubesd_query.py 0.00% 2 Missing :warning:
qubes/tools/qubes_create.py 0.00% 1 Missing :warning:
qubes/vm/__init__.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   70.55%   70.54%   -0.02%     
==========================================
  Files          61       61              
  Lines       13616    13644      +28     
==========================================
+ Hits         9607     9625      +18     
- Misses       4009     4019      +10     
Flag Coverage Δ
unittests 70.54% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 28 '25 13:08 codecov[bot]

Nice contribution! What's still needed for Python 3.14?

reneleonhardt avatar Sep 20 '25 05:09 reneleonhardt

Nice contribution! What's still needed for Python 3.14?

I am not certain. Some of the pending issues are tracked on the main Fedora 43 issue. Like this one.

alimirjamali avatar Sep 20 '25 09:09 alimirjamali

Thank you! So is there something missing to undraft and review this? 🙂

reneleonhardt avatar Sep 20 '25 10:09 reneleonhardt

Thank you! So is there something missing to undraft and review this? 🙂

Actually this is also ready for review. The only issue is lack of time. More information here.

alimirjamali avatar Sep 20 '25 10:09 alimirjamali

This PR is for dom0, and there are no plans to change Python version in R4.3 dom0 (it will stay at 3.13). This PR may be useful only for the future (R4.4 and beyond).

marmarek avatar Sep 20 '25 12:09 marmarek

What does may be useful mean? It may not be needed for R4.3 but it modernizes docs, tools, tests and vm while still working on 3.13 (Fedora 41 and 42) and allowing CI to prepare in time for the next Fedora ❤️

reneleonhardt avatar Sep 20 '25 13:09 reneleonhardt

Yes, but at this time "main" branch is open only for changes that are necessary for R4.3.

marmarek avatar Sep 20 '25 14:09 marmarek

I couldn't find this information in the README, only the master branch is being mentioned there. Maybe you want to make the documentation clearer or introduce a v4.4 integration branch for future features.

reneleonhardt avatar Sep 20 '25 15:09 reneleonhardt

See https://doc.qubes-os.org/en/latest/developer/releases/version-scheme.html#release-schedule Anyway, this is not the place for such discussion.

marmarek avatar Sep 20 '25 17:09 marmarek