qubes-core-admin-client icon indicating copy to clipboard operation
qubes-core-admin-client copied to clipboard

Remove `--just-db` option from auto-generated man of qvm-remove

Open jamke opened this issue 2 months ago • 2 comments

Remove --just-db option from auto-generated man of qvm-remove. I checked the code, qvm-remove does not support this option.

jamke avatar Oct 27 '25 07:10 jamke

Unintentionally made a second commit (Fix mistake in man qvm-template: use info instead of list). Reverted it.

jamke avatar Oct 27 '25 07:10 jamke

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 76.17%. Comparing base (f9eb4a5) to head (9c212e8). :warning: Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files          53       53           
  Lines        9250     9250           
=======================================
  Hits         7046     7046           
  Misses       2204     2204           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 27 '25 07:10 codecov[bot]

Is that second change unwanted? Looks like a good thing to fix too.

marmarek avatar Nov 05 '25 12:11 marmarek

Is that second change unwanted? Looks like a good thing to fix too.

I wanted to PR it later one by one. The second change is valid and correct, though. You may use it too if it's OK to combine changes like that.

jamke avatar Nov 05 '25 13:11 jamke

I merged the two fixes without the revert. Thanks!

marmarek avatar Nov 05 '25 14:11 marmarek