qubes-core-admin-client icon indicating copy to clipboard operation
qubes-core-admin-client copied to clipboard

Minor typo fixes in output when restoring a backup

Open jmynes opened this issue 3 months ago • 3 comments

I ran into a typo while using qvm-backup-restore, Exisiting --> Existing


This typo also appears in a few other files: https://github.com/search?q=org%3AQubesOS%20Exisiting&type=code

But I wasn't sure if these should be edited, or not.

jmynes avatar Sep 18 '25 15:09 jmynes

There is one more place in tests to update (it's hilarious to see test checking if you got the typo right :D)

marmarek avatar Sep 19 '25 01:09 marmarek

QubesOS/qubes-gui-agent-linux

* [pulse/pulsecore-0.9.21/aupdate.h](https://github.com/QubesOS/qubes-gui-agent-linux/blob/b1c52ac515556e3bb02c712d60d7105d5b98b994/pulse/pulsecore-0.9.21/aupdate.h#L50)

* [pulse/pulsecore-0.9.22/aupdate.h](https://github.com/QubesOS/qubes-gui-agent-linux/blob/b1c52ac515556e3bb02c712d60d7105d5b98b994/pulse/pulsecore-0.9.22/aupdate.h#L50)

* [pulse/pulsecore-0.9.23/aupdate.h](https://github.com/QubesOS/qubes-gui-agent-linux/blob/b1c52ac515556e3bb02c712d60d7105d5b98b994/pulse/pulsecore-0.9.23/aupdate.h#L50)

Those are imported from pulseaudio, so should remain unchanged (you may send a patch to pulseaudio project ;) )

QubesOS/qubes-posts

* [2017-04-26-qubes-compromise-recovery.md](https://github.com/QubesOS/qubes-posts/blob/05a8a728187978bf2d4a4e515f448f4180fef695/2017-04-26-qubes-compromise-recovery.md?plain=1#L286)

This shows an output of the tool at that time, should remain as is too.

marmarek avatar Sep 19 '25 01:09 marmarek

Looks like they fixed it 14 years ago in pulseaudio (along with many other typos in that commit 😅 )

https://github.com/pulseaudio/pulseaudio/commit/c5dca7cf2b0423f152c6e81a503cc9639b08f09f

Thanks for the quick turnaround

jmynes avatar Sep 19 '25 14:09 jmynes