pyquarkchain icon indicating copy to clipboard operation
pyquarkchain copied to clipboard

integrity check of local db

Open qizhou opened this issue 5 years ago • 4 comments

Make sure if we change the code, the code can recognize local db, i.e., we don't break the existing consensus.

A couple of checks:

  • Check every root block
  • Check every minor block
  • Check block index to block map
  • Check x-shard transactions etc.

qizhou avatar Jun 28 '19 18:06 qizhou

seems done, should close? @qizhou

ninjaahhh avatar Jul 24 '19 18:07 ninjaahhh

May need the last steps of checking xshard txs.

qizhou avatar Jul 24 '19 23:07 qizhou

what should we check for xshard txs? in my understanding, CheckMinorBlock already checks 1) processing xshard deposits; 2) processing xshard tx on the sender side

ninjaahhh avatar Aug 06 '19 19:08 ninjaahhh

We should check the xshard deposits on target shard matches the one of the local shard.

  • Qi

On Tue, Aug 6, 2019 at 12:04 PM ninjaahhh [email protected] wrote:

what should we check for xshard txs? in my understanding, CheckMinorBlock already checks 1) processing xshard deposits; 2) processing xshard tx on the sender side

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/QuarkChain/pyquarkchain/issues/593?email_source=notifications&email_token=AATMNZT3UNFOJFDHJ3PPXZLQDHDMNA5CNFSM4H4HUTG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WEULA#issuecomment-518801964, or mute the thread https://github.com/notifications/unsubscribe-auth/AATMNZVYNKHTF437HRQF2STQDHDMNANCNFSM4H4HUTGQ .

qizhou avatar Aug 06 '19 20:08 qizhou