pyquarkchain icon indicating copy to clipboard operation
pyquarkchain copied to clipboard

Published 20 hours ago • verified publisher icon QuarkChain

fully integrate EIP-712

Open qcdll opened this issue 6 years ago • 0 comments

currently, pyquarkchain's transaction include a field called version which signifies how the transaction is signed: https://github.com/QuarkChain/pyquarkchain/blob/3648337b86bd9716fccd8106d98ac7c59f38a2ee/quarkchain/evm/transactions.py#L64 0 means the signature is generated in a similar way to ethereum transactions 1 means the signature is generated based on typed signature (EIP-712) as implemented by MetaMask BEFORE #4803

after Metamask 4803 is pushed, it will be a breaking change for MetaMask users of our testnet, so we need to upgrade accordingly

qcdll avatar Sep 25 '18 19:09 qcdll