RedReader icon indicating copy to clipboard operation
RedReader copied to clipboard

Improvements to Find Subreddit

Open QuantumBadger opened this issue 3 years ago • 3 comments

  • [X] Rename to "Find Location"
  • [X] Add buttons for quickly jumping to subreddit, user, URL, or post search
  • [x] Fix issue with loading spinner sometimes not appearing
  • [ ] Make Custom Location a separate menu item again
  • [ ] Update migration: Disable "Custom Location" preference if "Find Location" is enabled
  • [x] Don't re-download subscriptions (re-use existing database)
  • [x] Hide subreddit description and subscriber count for subscriptions
  • [ ] Include pinned and history subreddits in the search list
  • [x] Hide keyboard when the "Search" button is pressed

QuantumBadger avatar Jun 27 '22 14:06 QuantumBadger

@QuantumBadger whatever it is you did for this I think it sped up the whole app. 👍

Some issues I had with cache loading and the wheel spinning for a long time seem to be gone now. I will report back when I do some more testing but again this fix is great.

japanesephundroid avatar Sep 03 '22 19:09 japanesephundroid

Re the hiding keyboard improvement - is this not just a matter of adding a searchView.clearFocus(); inside onQueryTextSubmit?

Only problem would be that it doesn't hide keyboard if there's no input (guess depends what the desired behaviour here is)

mattdbr avatar Jul 09 '23 12:07 mattdbr