Yao.jl icon indicating copy to clipboard operation
Yao.jl copied to clipboard

dispatch(Ry(0), :random) is not working correctly

Open simonschnake opened this issue 2 years ago • 1 comments

Dear all,

dispatch(Ry(0), :random)

is setting the angle theta in the range of [0, 1], which is probably not wanted.

Thank you Simon

simonschnake avatar Oct 04 '23 10:10 simonschnake

Hi, thanks for the issue. The following patch would immediately fix the issue:

julia> Yao.render_params(r::RotationGate, ::Val{:random}) = (rand()*2π,)

Do you think we should merge it to Yao so that it can be the default behavior? I am a bit worried that users would think this behavior can be not very predictable. For example, the time evolution block still generate random t in range [0, 1] for no reason.

GiggleLiu avatar Oct 04 '23 10:10 GiggleLiu