quacc icon indicating copy to clipboard operation
quacc copied to clipboard

List path to solve issue 1905

Open mhbarrie opened this issue 1 year ago • 2 comments

Summary of Changes

Modify settings. py validation Using a loop to find if the List [path] configuration file exists and implements List[path]

Closes #2055.

Checklist

  • [X ] I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • [X ] My PR is on a custom branch and is not named main.
  • [ X] I have added relevant, comprehensive unit tests.

mhbarrie avatar Apr 25 '24 02:04 mhbarrie

Can one of the admins verify this patch?

buildbot-princeton avatar Apr 25 '24 02:04 buildbot-princeton

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 98.94%. Comparing base (a1145cc) to head (72579e8). Report is 25 commits behind head on main.

:exclamation: Current head 72579e8 differs from pull request most recent head dec11ea. Consider uploading reports for the commit dec11ea to get more accurate results

Files Patch % Lines
src/quacc/calculators/vasp/vasp.py 89.47% 2 Missing :warning:
src/quacc/calculators/espresso/espresso.py 88.88% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
- Coverage   99.00%   98.94%   -0.06%     
==========================================
  Files          81       81              
  Lines        3309     3328      +19     
==========================================
+ Hits         3276     3293      +17     
- Misses         33       35       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 02:04 codecov[bot]

Hi @mhbarrie! Are you interested in continuing this PR? Thanks again for your work on this.

Andrew-S-Rosen avatar May 09 '24 05:05 Andrew-S-Rosen