quacc icon indicating copy to clipboard operation
quacc copied to clipboard

Write out results to JSON instead of pickle

Open Andrew-S-Rosen opened this issue 1 year ago • 1 comments

Summary of Changes

Write out the results to a JSON file instead of a pickle file to prevent potential security issues.

Requires:

  • New monty version

Checklist

  • [X] I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • [X] My PR is on a custom branch and is not named main.
  • [X] I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

Andrew-S-Rosen avatar Apr 21 '24 05:04 Andrew-S-Rosen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.04%. Comparing base (56c1caf) to head (88cd57a).

:exclamation: Current head 88cd57a differs from pull request most recent head 6dc814c. Consider uploading reports for the commit 6dc814c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2025   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          81       81           
  Lines        3339     3339           
=======================================
  Hits         3307     3307           
  Misses         32       32           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 21 '24 05:04 codecov[bot]